search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

Update Tags.java #352

Closed limfriend closed 5 years ago

limfriend commented 5 years ago

add tag 'error_kind'

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.2%) to 76.009% when pulling abc408cf7e5ae8ff6eb09adf93330b201dd7551c on limfriend:patch-1 into d91d7072e141fa66265946b5164c249bf3045017 on opentracing:master.

whiskeysierra commented 5 years ago

https://static.javadoc.io/io.opentracing/opentracing-api/0.33.0/io/opentracing/log/Fields.html#ERROR_KIND

It's a log field, not a tag.

whiskeysierra commented 5 years ago

See also https://github.com/opentracing/specification/blob/master/semantic_conventions.md

limfriend commented 5 years ago

https://static.javadoc.io/io.opentracing/opentracing-api/0.33.0/io/opentracing/log/Fields.html#ERROR_KIND

It's a log field, not a tag. 'error.kind' is very important , we should be easy to search and stat it. it is difficulty to search when ''error.kind' is log field