Log an error when Scope.close() is called on the incorrect object.

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163

http://opentracing.io

Apache License 2.0

1.68k stars 344 forks source link

Log an error when Scope.close() is called on the incorrect object. #369

Open carlosalberto opened 4 years ago

carlosalberto commented 4 years ago

A few users have complained about not getting any warning when closing a non-active Scope, so this PR tries to do a simple warning.

(Prior-art wise, grpc's Context implementation does the very same ;) )

coveralls commented 4 years ago

Coverage increased (+0.2%) to 76.739% when pulling ee859f46e42009e1c6b8b703da3a5c3c9f3c3119 on log_warning_scope_close into d74e4675a1822c2549ba26c6d67c9fa033e1813b on master.

carlosalberto commented 4 years ago

Any opinion or similar on this one @yurishkuro @sjoerdtalsma ?