search

opentracing / opentracing-java

OpenTracing API for Java. 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.68k stars 344 forks source link

TextMapInjectAdapter does not implement TextMap #370

Closed prsh9 closed 4 years ago

prsh9 commented 4 years ago

TextMapInjectAdapter cannot be used in the tracer.inject() API as the current implementation of TextMapInjectAdapter does not implement TextMap. https://github.com/opentracing/opentracing-java/blob/master/opentracing-api/src/main/java/io/opentracing/propagation/TextMapInjectAdapter.java#L30 As seen in the implementation TextMapInjectAdapter implements TextMapInject but it does not implement TextMap in the hierarchy

whiskeysierra commented 4 years ago

Maybe this helps:

extract(TEXT_MAP) inject(TEXT_MAP) extract(TEXT_MAP_EXTRACT) inject(TEXT_MAP_INJECT)
TextMapAdapter ✔️ ✔️ ✔️ ✔️
TextMapExtractAdapter ❌ ❌ ✔️ ❌
TextMapInjectAdapter ❌ ❌ ❌ ✔️