opentracing / opentracing-javascript

OpenTracing API for Javascript (both Node and browser). 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.09k stars 108 forks source link

Inject and Extract with BINARY format #130

Closed CHOMNANP closed 5 years ago

CHOMNANP commented 5 years ago

I have tried and cannot manage to get the Inject and extract with Binary work across 2 node on microservice. The communication between service is using rabitMQ.

Can anyone help guild me how to get it done?

florianrusch commented 5 years ago

Please correct me, if I'm wrong: For me it looks like there is no logic behind the inject/extract functions.

https://github.com/opentracing/opentracing-javascript/blob/cb74683fefe5bd4d711eaa0c273f3fc17a6c3781/src/tracer.ts#L172-L179

CHOMNANP commented 5 years ago

I got a working way around with TEXT_MAP_FORMAT. https://github.com/jaegertracing/jaeger-client-node/issues/370

Thank.