Closed jdmoody closed 3 years ago
There seems to be a legitimate circular dependency here that causes problems when I build this library using Snowpack:
I think it should be fixed by simply importing SpanContext directly rather than importing the full ./index.ts.
SpanContext
Coverage remained the same at 88.889% when pulling 386e6ad5dfd73225a37bb3d520c94de0eac97477 on jdmoody:fix-mock-context-cycle into 07e847fe95e05ffc5a2e40ce3f0215b889807dc9 on opentracing:master.
Thanks for the quick review + merge! 🙏
I'd love to get a patch version with this out, if possible. I believe anyone trying to use opentracing with Snowpack will run into this, otherwise.
Released as v0.14.15
v0.14.15
There seems to be a legitimate circular dependency here that causes problems when I build this library using Snowpack:
I think it should be fixed by simply importing
SpanContext
directly rather than importing the full ./index.ts.