search

opentracing / opentracing-javascript

OpenTracing API for Javascript (both Node and browser). 🛑 This library is DEPRECATED! https://github.com/opentracing/specification/issues/163
http://opentracing.io
Apache License 2.0
1.09k stars 108 forks source link

Added the mock_tracer to the opentracing export #90

Closed jhorowitz closed 6 years ago

jhorowitz commented 6 years ago

In reference to https://github.com/opentracing/opentracing-javascript/issues/89

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-26.8%) to 62.025% when pulling a76dc51c9ed1c97d6ca2ad0e9c85a7daf4f0e6d2 on jhorowitz:testing/mock into 1f32ae4aa77b866dce23ef6e33a3b9b08d458171 on opentracing:master.

yurishkuro commented 6 years ago

don't know why the build is failing.

is it possible to have a unit test that relies on the new import?

jhorowitz commented 6 years ago

I'm not sure what you mean. Do you mean write unit tests for mock_tracer or fool the coverage so the build works? I'm planning on writing unit tests for mock_tracer but I don't have enough bandwidth to do that today.

yurishkuro commented 6 years ago

I restarted the build, let's see if it succeeds. master branch is green, so no reason it shouldn't work in this PR.

What I meant by the import is if you look at https://github.com/opentracing/opentracing-javascript/issues/91#issuecomment-348313018 the import is done as import { MockTracer } from '../mock_tracer'; Instead is should be doing the import via ../index using the change from this PR.

jhorowitz commented 6 years ago

I see. I'll tackle this on Monday

yurishkuro commented 6 years ago

Done in #98