opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

Added support for PHP 8 #112

Closed omnilight closed 3 years ago

omnilight commented 3 years ago

Short description of what this PR does:

Checklist

Relates to #93

omnilight commented 3 years ago

Had to remove --prefer-lowest from tests, due to the errors. Looks like we have to make it as a separate PR

omnilight commented 3 years ago

Working on fixing tests

jcchavezs commented 3 years ago

Awesome

On Thu, 3 Dec 2020, 10:51 Pavel, notifications@github.com wrote:

Working on fixing tests

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/opentracing/opentracing-php/pull/112#issuecomment-737802023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAV2VTBQMID34ALQF6TSS5NQJANCNFSM4UIYDHOA .

omnilight commented 3 years ago

All tests have been passed. Could we merge this and release new beta?

jcchavezs commented 3 years ago

Thanks a lot for this!