Getting rid of $logRecords argument from Span::finish()

[ellisv]

Background

Current interface looks as such

public function finish($finishTime = null, array $logRecords = []);

PHP docs does not say anything about this optional $logRecords parameter but I assume it logs events before finishing the span.

Problem

• Method finish() does more than one thing
• This feature is not found on any other opentracing library. For sake of consistency it'd be good to have very similar APIs

Proposal

Getting rid of $logRecords argument for Span::finish(). I think it is better to do it explicitly like

$span->log([...])
$span->finish();