search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
505 stars 56 forks source link

fix unset exception in MockScopeManager deactivate #72

Closed xubeijun closed 6 years ago

xubeijun commented 6 years ago
jcchavezs commented 6 years ago

This is related: https://github.com/DataDog/dd-trace-php/pull/18/files

xubeijun commented 6 years ago

In my point, the "foreach" is more efficient than "for".

jcchavezs commented 6 years ago

@freedom-diy it looks good to me. Would you mind to add a test covering this situation?

PS. You can fix the link with composer fix-lint.

xubeijun commented 6 years ago

@jcchavezs Could you merge this feature to master?

jcchavezs commented 6 years ago

@freedom-diy sure, we just need to lint to be fixed. Check this comment: https://github.com/opentracing/opentracing-php/pull/72#issuecomment-398989816

xubeijun commented 6 years ago

@jcchavezs done

jcchavezs commented 6 years ago

@freedom-diy my fault I did not request for a test. Could you please cover this case with a test?

You can use this as guide: https://github.com/DataDog/dd-trace-php/pull/18/files#diff-c3cd9e81f4a796d976b75434610be3d9R53