opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
508 stars 56 forks source link

Fix: Composer resolves binaries itself #76

Closed localheinz closed 6 years ago

localheinz commented 6 years ago

Short description of what this PR does:

💁‍♂️ For reference, see https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands:

Note: Before executing scripts, Composer's bin-dir is temporarily pushed on top of the PATH environment variable so that binaries of dependencies are easily accessible. In this example no matter if the phpunit binary is actually in vendor/bin/phpunit or bin/phpunit it will be found and executed.

Follows https://github.com/opentracing/opentracing-php/pull/65#discussion_r202249213.

Checklist

localheinz commented 6 years ago

Thank you, @jcchavezs!

jcchavezs commented 6 years ago

@localheinz if you don't mind I will borrow this changes into https://github.com/jcchavezs/zipkin-php. Unless you want to do it yourself (which sounds more fair to me).

localheinz commented 6 years ago

@jcchavezs

Go for it! 🤓

piotrooo commented 5 years ago

How is going work of this changes?

cc: @localheinz, @jcchavezs

jcchavezs commented 5 years ago

I don't get the question :(

José Carlos Chávez

man. 1. apr. 2019 kl. 21:58 skrev Piotr Olaszewski <notifications@github.com

:

How is going work of this changes?

cc: @localheinz https://github.com/localheinz, @jcchavezs https://github.com/jcchavezs

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opentracing/opentracing-php/pull/76#issuecomment-478723942, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7sAt_dAdd5Q7qKQVQBGJUfNNbirSG9ks5vcmT1gaJpZM4VOcZK .