search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
509 stars 56 forks source link

New php versions #87

Closed piotrooo closed 5 years ago

piotrooo commented 5 years ago

Travis configuration for PHP 7.1, 7.2 and 7.3. Bumped phpunit. Fixed tests.

Close #74. Close #65.

jcchavezs commented 5 years ago

I agree, we can get rid of 7.0. Since the only more or less used instrumentation using opentracing is https://github.com/jcchavezs/zipkin-php-opentracing and zipkin-php is soon going to use php 7.1 (see this).

Also DDTrace is not OpenTracing native: https://github.com/DataDog/dd-trace-php/commit/237e3b60773d3ba7cbafaa8d6652dd0f0e7c7985#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 but provides a compatible bridge. Worth to mention, DDTrace supports PHP 5.4: https://github.com/DataDog/dd-trace-php/blob/master/composer.json#L23 so OT is incompatible already for some PHP versions.

cc @pawelchcki @ellisv

piotrooo commented 5 years ago

@jcchavezs any news?

jcchavezs commented 5 years ago

I al going to merge this if no further complaints.

lør. 6. apr. 2019, 08:49 skrev Piotr Olaszewski notifications@github.com:

@jcchavezs https://github.com/jcchavezs any news?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opentracing/opentracing-php/pull/87#issuecomment-480479786, or mute the thread https://github.com/notifications/unsubscribe-auth/AC7sAi6JR1add9LiDpvWEgag9b9SnWovks5veEOCgaJpZM4cbU1q .