search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
508 stars 56 forks source link

Type hinting #88

Closed piotrooo closed 5 years ago

piotrooo commented 5 years ago

Hi, now we have on our master branch PHP >= 7.1, maybe next step is use type hinting?

I have been done with some changes, almost all classes covered that changes. What do you think about it?

jcchavezs commented 5 years ago

I think this is the next natural step. A PR for this is welcome.

sergeyklay commented 5 years ago

@jcchavezs Consider to create a tag before merging to upstream

Reasno commented 4 years ago

A friendly reminder, this is a breaking change.

jcchavezs commented 4 years ago

Hi @reasno, truth is PHP 5.6 is long deprecated and we are moving the compatibility to PHP 7.2 to take advantages of typing in PHP and reduce the boiler plate in implementations.

Reasno commented 4 years ago

Hi @Reasno, truth is PHP 5.6 is long deprecated and we are moving the compatibility to PHP 7.2 to take advantages of typing in PHP and reduce the boiler plate in implementations.

I am looking forward to it. Hope OT implemetations can keep up the pace.