search

opentracing / opentracing-php

OpenTracing API for PHP
Apache License 2.0
509 stars 56 forks source link

Noop repackage #90

Closed piotrooo closed 4 years ago

piotrooo commented 5 years ago

After reading a specification I was discovered a following sentence.

In some cases (for example, Java) the NoopTracer may be in its own packaging artifact.

So maybe we should repackage a Noop related classes to the new package called Noop (like a mocks).

This will allow us to better organize classes, without mixing contents.

jcchavezs commented 5 years ago

Mixed feelings here. I tried this before (along with a new package for Mock) but we decided to keep it as it is. If have time I will check the original discussion when back from holidays.

jcchavezs commented 5 years ago

Check this discussion: https://github.com/opentracing/opentracing-php/pull/46#issuecomment-362558775

piotrooo commented 5 years ago

@jcchavezs how Noop classes are related with the Mock classes? And how repackage of that Noop* classes can interfere with whole codebase?

jcchavezs commented 4 years ago

They are different but the argument was the same.