opentraveldata / opentraveldata

Collection of open data related to (at least) travel, transport, tourism
https://opentraveldata.github.io/opentraveldata/
239 stars 101 forks source link

New currency VES (replacing VEF) in Venezuela #148

Closed MrMey closed 4 years ago

MrMey commented 4 years ago

Hello Denis, After looking at Geonames and Wikipedia, I bumped into the fact that Venezuela changed its currency in 2018 (VES). After a look in the optd_por_public.csv, it seems Venezuela still have the old currency (VEF).

Romain Bests

da115115 commented 4 years ago

Thanks Romain, good catch!

The currency codes are retrieved by OPTD from the opentraveldata/optd_countries.csv file.

That file itself is being derived manually (every so often) thanks to the tools/make_optd_country.sh Shell script (and associated tools/make_optd_country.awk AWK script).

So, I just re-ran it, thanks to you (!), and updated the OPTD POR files.

So, we had a few other updates of currencies, for instance for:

38d5fbeafefa9dcad97933254167812bf00346b7 brings all those changes.

Do not hesitate to remind me/us in the future when the country details have changed.

MrMey commented 4 years ago

Hello, I think the currency of San Tome and Principe is STN and not STD as in the optd_countries.csv.

Apparently it did change in 2018 (see Wikipedia)

In fact I used data from the organization that maintains the currency standard ISO4217. They publish on their website two documents (xls and xml) with the currencies per country (+some additional currencies). Looking at the website activity, it seems they keep it up-to-date. Maybe the xml version could be used to validate the currencies.

Their policy states these documents are free-to-use:

ISO allows free-of-charge use of its country, currency and language codes from ISO 3166, ISO 4217 and ISO 639, respectively.

Note that it would require a small matching step because the country name they use do not match perfectly yours (for example the stop words position may change like Bahamas vs BAHAMAS (THE)).