opentraveldata / opentraveldata

Collection of open data related to (at least) travel, transport, tourism
https://opentraveldata.github.io/opentraveldata/
240 stars 101 forks source link

Feature Request: Include currency codes #30

Closed tadhgpearson closed 8 years ago

tadhgpearson commented 8 years ago

It would be very useful to include the ISO 4217 currency code in either optd_country_region_info.csv or optd_por_public.csv

Currently we use this data to back sandbox.amadeus.com, and being able to display the currency of the city is a popular request. The use case is obvious: when the developer identifies the traveler's nearest relevant airport, they want to be able to display the results of flight/car/hotel searches in the traveler's currency. As a result, they need that currency data when they look up the location.

In the sandbox, we provide this in the output, merging it with a simple gist we found when the data is uploaded to our service. But we would much rather it comes from Open Travel Data ;)

I can see you have some currency related elements in here already - https://github.com/opentraveldata/opentraveldata/tree/master/data/currency/ccy - but it doesn't seem to be used.

Could we include the currency in one or more of the maintained output data files?

alexprengere commented 8 years ago

Hi, Not really answering your question, but I have had the same use case and I used the GeoNames data to map a country code to a currency code (and obviously opentraveldata to map a point of interest to a country code). It is already included in GeoBases with data=countries.

tadhgpearson commented 8 years ago

Thanks Alex. That looks a bit more 'official' than what I used :) So, this sounds like a common use case, why don't be add it to the output data? Do you think it's better to map it as part of the countries file, or also in the POR file?

alexprengere commented 8 years ago

Since the use case is pretty common, indeed we could add it to the POR file, to be able to directly map any airport to its currency, the same way we already do for country names, continents, etc..

tadhgpearson commented 8 years ago

Woohoo!