search

opentrials / opentrials-early-poc

A very early POC app for OpenTrials, just using a single source of data on schizophrenia.
MIT License
1 stars 0 forks source link

Feature/suggestions from code review #14

Closed kravets-levko closed 9 years ago

pwalsh commented 9 years ago

@kravets-levko thanks. looks fine but still not sure why you have nested routers: ie - routers in each controller, and then using them in the routes lib too. I personally would just have the routing stuff in the routes lib, and not the controllers lib. Maybe you have a reason for doing it like this? In any event, don't get held up on that now.

kravets-levko commented 9 years ago

@pwalsh I've made this because after reading express.js docs I decided that it would be good thing to have each controller as a finished component of application that does not export any additional stuff, just a "component" itself. Of course, this is a subject to discuss.

pwalsh commented 9 years ago

@kravets-levko ok.