Remove TRAINISH and BUSISH

[abyrd]

The TRAINISH and BUSISH modes seem like a mistake and should probably be removed. No one intuitively knows what they mean, they make the available modes non-mutually-exclusive, and as far as I know they are not used anywhere.

[mvandertuin]

Hi @abyrd,

I'm trying to fix this issue, but I have a few questions regarding the Cable Car mode:

• What would be the intended behaviour if you select "Bus only" at the user interface? At the moment, both "Bus" and "Cable Car" are included if this option is selected. Is this indeed the intended behaviour? I would expect only "Bus" as the used mode if I select the bus only option in the interface. (code here at line 288)
• When I added CABLE_CAR to the "bus only" option, I received an error that TraverseMode.CABLE cannot be found. I've got the idea that this is due to the splitting of qualified modes according to the underscore (code here at line 67). Since CABLE_CAR includes an underscore itself, CABLE is the resulting mode instead of CABLE_CAR. Is this indeed a bug?
• What should be the intended behaviour of method calcPlatform(TraverseModeSet mode) in org.opentripplanner.routing.impl.CandidateEdge? Should the Cable Car platform indeed receive the value StreetEdge.CLASS_OTHER_PLATFORM, or was this originally not intended? (code here at line 198)
• Do you know a test set where a Cable Car is present so I'm able to test it on a running instance?

[mvandertuin]

I added a Pull Request which fixes the issue. Regarding the questions I asked, I made the following choices:

• If Bus Only is selected, only Bus and Walk are added as modes. Cable Car was removed.
• The potential Cable Car bug remains. It should be tested/confirmed before removing the underscore I think.
• The Cable Car receives the StreetEdge.CLASS_OTHER_PLATFORM class.
• I was not able to test the Cable Car mode since I don't have a test set for that.

[3vivekb]

We are having a weird issue where if BUSISH and TRAINISH is selected, the algorithm will happily have a person take light rail to get to the destination. But if BUSISH is not selected, the person won't take light rail and would rather walk. Is this a related issue?

[abyrd]

In the code:

    private static final int MODE_TRAINISH = MODE_TRAM | MODE_RAIL | MODE_SUBWAY | MODE_FUNICULAR | MODE_GONDOLA;
    private static final int MODE_BUSISH = MODE_CABLE_CAR | MODE_BUS;

These modes are counterintuitive and should really just be removed (and we have a PR to do that), but BUSISH should only affect cable cars and buses. @3vivekb maybe your input data has the light rail defined as a bus?

[3vivekb]

Hey @abyrd , We checked out GTFS and light rail isn't defined as bus. We went from v 19 to v 20 and it seems to be working better (sometimes walk + train + bus is slower than walk + train).