opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.13k stars 1.01k forks source link

IntermediatePlaces not working for isochrones #2883

Closed Erhanjinn closed 3 years ago

Erhanjinn commented 4 years ago

Dear OpenTripPlanner devs,

I have found a bug in either OpenTripPlaneer itself or in its documentation. According to http://dev.opentripplanner.org/apidoc/1.3.0/resource_LIsochrone.html isochrone endpoint supports intermediatePlaces, however I get the same results whether I submit this parameter or not. It seems to not have any effect.

Both

http://localhost:8095/otp/routers/mycity/isochrone?fromPlace=50.100762330354975,14.450111389160158&intermediatePlaces=50.098009491894516,14.420070648193361&mode=WALK,CAR&date=05-02-2019&time=7:30am&maxWalkDistance=500&cutoffSec=1200

and

http://localhost:8095/otp/routers/mycity/isochrone?fromPlace=50.100762330354975,14.450111389160158&mode=WALK,CAR&date=05-02-2019&time=7:30am&maxWalkDistance=500&cutoffSec=1200

give the same results. Is the intermediatePlaces parameter even intended to work with isochrones?

Thanks

Jan

abyrd commented 3 years ago

No, I'm not even sure what IntermediatePlaces would mean when generating isochrones.

The API docs are automatically generated. Every HTTP API endpoint that is defined by a subclass of RoutingResource will accept every possible routing parameter, but they don't necessarily do anything.