search

opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.16k stars 1.02k forks source link

Various bugs in the graphql API #3071

Closed satabin closed 2 years ago

satabin commented 4 years ago

In the current graphql API, call may crash when

Expected behavior

The calls don't crash. The semantic hash is returned, and the scheduled timetable is used

Observed behavior

Cast or null pointer exceptions are raised.

Version of OTP used (exact commit hash or JAR name)

33a85ef9af5d1f3f028c34d1f328adb30e2cf25f

Data sets in use (links to GTFS and OSM PBF files)

N/A

Command line used to start OTP

N/A

Router config and graph build config JSON

N/A

Steps to reproduce the problem

Query a trip with its semanticHash or stoptimeForDate on a data set with no updater.

t2gran commented 4 years ago

The OTP1 GraphQL API is not maintained, I would recommend using the HSL fork version or maintaining your private fork until you can switch to OTP2.

satabin commented 4 years ago

Hi @t2gran thanks for the answer and suggestion.

leonardehrenfried commented 2 years ago

Hey @satabin ( :) ), does this problem still happen in OTP2?

satabin commented 2 years ago

This part was completely rewritten in OTP2, so they probably don’t.

I’m closing this, I thought I did it before.