Remove or re-enable ignored tests

[hannesj]

Currently we have quite many disabled tests, which should be either fixed, re-implemented, removed, or be better documented

• [x] org.opentripplanner.ext.datastore.gs.GsIntegrationTest
  • Run manually, as it requires Google Cloud Store to run
• [x] org.opentripplanner.graph_builder.linking.LinkStopToPlatformTest.testLinkStopWithExtraEdges
  • Re-enable, requires areaVisibility to be enabled
• [x] org.opentripplanner.graph_builder.module.ElevationModuleTest.testSetElevationOnEdgesUsingS3BucketTiles
  • Run manually due to test requiring internet
• [x] org.opentripplanner.graph_builder.module.osm.TestIntermediatePlaces
  • Move to some other place, intermediate places need to be implemented
• [x] org.opentripplanner.mmri.AllModesAndAgenciesTest
  • Requires stop-to-stop transfers without street network
• [x] org.opentripplanner.mmri.ExcludedStopsTest
  • Requires stop banning
• [x] org.opentripplanner.mmri.OnTripTest
  • Requires departing onboard trip
• [x] org.opentripplanner.mmri.PlannerstackScenarioTest
  • Requires departing onboard a trip
• [x] org.opentripplanner.mmri.PreferencesTest
  • Unknown failure
• [x] org.opentripplanner.mmri.ServiceAlertTest
  • Service alerts not mapped correctly
• [x] org.opentripplanner.mmri.TimeTest
  • Unknown failure
• [x] org.opentripplanner.mmri.TransferTimeTest
  • Requires stop-to-stop transfers without street network
• [x] org.opentripplanner.routing.algorithm.StreetModeLinkingTest.testWheelchairLinking
  • Linking to wheelchair accessible streets is currently not implemented
• [x] org.opentripplanner.routing.algorithm.TestAStar
  • Remove, testing removed functionality
• [x] org.opentripplanner.routing.algorithm.TestGraphPath.testGraphPathOptimize
  • GraphPath optimization was removed, test can be too. However, we might want to add tests to graph path generation
• [x] org.opentripplanner.routing.algorithm.mapping.TransitSnapshotTest.test_trip_planning_with_transit
  • Issue with floating-point maths stability
• [x] org.opentripplanner.routing.edgetype.PatternInterlineDwellTest
  • Should be moved to a module test, checking that itinerary has no transfers with an stay-seated transfer
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testFewestTransfers
  • Remove, optimization type related to OTP1
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testFrequencies
  • Add module test + unit test for mapper
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testIssue
  • Should be converted to proper unit test
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testPathways
  • Convert to module test
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testPickupDropoff
  • Should be converted to proper unit test in org.opentripplanner.routing.algorithm.raptoradapter.transit.request, mapping to OTP model already covered
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testRouting
  • Remove, covered by other tests
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testRoutingOverMidnight
  • Convert to module test
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testRunForTrain
  • Should be converted to module test, if still needed
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testTimelessStops
  • Should be converted to proper unit test
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testTraverseMode
  • Remove, covered by RoutingRequestTransitDataProviderFilterTest
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testTripBikesAllowed
  • Remove, covered by RoutingRequestTransitDataProviderFilterTest
• [x] org.opentripplanner.routing.edgetype.loader.TestGeometryAndBlockProcessor.testWheelchairAccessible
  • Remove, covered by other tests, potentially add module test for checking intra-station routing
• [x] org.opentripplanner.routing.edgetype.loader.TestHopFactory
  • Can be removed, covered by other tests
• [x] org.opentripplanner.routing.graphfinder.StreetGraphFinderTest
  • Needs implementation
• [ ] org.opentripplanner.transit.raptor.moduletests.B12_MultipleOptimalAccessOptions.multiCriteria
  • Bug with onBoard multi-criteria pareto function
• [x] org.opentripplanner.updater.vehicle_rental.datasources.GbfsFeedLoaderTest.fetchAllPublicFeeds
  • Run manually due to test requiring internet
• [x] org.opentripplanner.updater.vehicle_rental.datasources.GbfsFeedLoaderTest.testSpin
  • Run manually due to test requiring internet
• [x] org.opentripplanner.util.logging.ThrottleLoggerTest
  • Test run manually

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

[leonardehrenfried]

All test in the list have been either removed or enabled.