search

opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.16k stars 1.02k forks source link

OSM BoardingLocations are not connected to the graph without explicit connection #5032

Open dekarl opened 1 year ago

dekarl commented 1 year ago

While testing #4903 I stumbled upon what appears to be a missing feature in OSM BoardingLocation support.

Expected behavior

OSM BoardingLocations, like highway=bus_stop, are connected to the walking graph. Even if they are "floating island nodes" without an explicit connection to the OSM network.

How to map A bus stop should be defined for each discrete location where a pole or shelter is placed or where a person should wait for a vehicle. The widely used approach is to place bus stop nodes off to one side of the highway way, and not with the node being part of the highway=* way (being the place where the vehicle stops - see below). If there are places for passengers to wait on both sides of the road then two bus stops should be defined.

From: https://wiki.openstreetmap.org/wiki/Tag:highway%3Dbus_stop#How_to_map

Observed behavior

OSM BoardingLocations, that are islands, are pruned from the graph before having a chance of being mapped to NeTEx Quays.

Version of OTP used (exact commit hash or JAR name)

c523aecaa5e675307d738217c702b87e1f0a1087

Data sets in use (links to GTFS and OSM PBF files)

https://download.geofabrik.de/europe/germany.html https://www.opendata-oepnv.de/ht/de/organisation/delfi/startseite?tx_vrrkit_view%5Bdataset_name%5D=deutschlandweite-sollfahrplandaten&tx_vrrkit_view%5Baction%5D=details&tx_vrrkit_view%5Bcontroller%5D=View

Command line used to start OTP

Router config and graph build config JSON

Steps to reproduce the problem

dekarl commented 1 year ago

I have since looked at the code with @leonardehrenfried and it appears that the issue is due to nodes without any way being ignored. The code to import osm goes over the ways (and their nodes).

github-actions[bot] commented 9 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days