search

opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.17k stars 1.02k forks source link

OSMSpecifier is mismatching parameters, shows up as naming issues in itinerary #507

Closed PJHouser closed 13 years ago

PJHouser commented 13 years ago

Naming issues, probably coming from the OSMSpecifier code - isn't this where the left/right algorithm was added? OTP is no longer properly matching parameters. It seems to choose a string that kinda matches, but comes second to what is actually the correct match. The tags for crosswalk comes last in the DefaultWayPropertyblahblah, but OTP ignores all closer matches and chooses crosswalk, even if the feature has no crosswalk tag.

Things that aren't a crosswalk, or even remotely close to a crosswalk, are being labeled a crosswalk. Alleys are being called parking aisles. Underpass is not being used. Footbridges are being called crosswalks.

If the names are screwed up because of OSMSpecifier, I imagine the weights are probably being misapplied also.

Examples to follow.

PJHouser commented 13 years ago

Paths and footways (being called crosswalks):

http://maps5.trimet.org/opentripplanner-webapp/?purl=/test&submit&fromPlace=45.497753472696,-122.64351599969&toPlace=45.498426530209,-122.6413755969&mode=WALK&min=QUICK&maxWalkDistance=840&time=3:20%20pm&date=09/13/2011&arr=Depart&itinID=1

Platform (being called a crosswalk):

http://maps5.trimet.org/opentripplanner-webapp/?purl=/test&submit&fromPlace=45.530091114711,-122.65420665304&toPlace=45.530093694299,-122.65299210806&mode=WALK&min=QUICK&maxWalkDistance=840&time=3:20%20pm&date=09/13/2011&arr=Depart&itinID=1

Alley (being called a parking lot):

http://maps5.trimet.org/opentripplanner-webapp/?purl=/test&submit&fromPlace=45.511953656135,-122.65250676418&toPlace=45.510171780421,-122.6504307344&mode=WALK&min=QUICK&maxWalkDistance=840&time=3:20%20pm&date=09/13/2011&arr=Depart&itinID=1

Footbridge (being called a crosswalk):

http://maps5.trimet.org/opentripplanner-webapp/?purl=/test&submit&fromPlace=45.497057067767,-122.64493555402&toPlace=45.496756253618,-122.64788598393&mode=WALK&min=QUICK&maxWalkDistance=840&time=3:20%20pm&date=09/13/2011&arr=Depart&itinID=1

Underpass (being called a crosswalk again):

http://maps5.trimet.org/opentripplanner-webapp/?purl=/test&submit&fromPlace=45.500067771303,-122.67753516071&toPlace=45.500453632788,-122.67765772802&mode=WALK&min=QUICK&maxWalkDistance=840&time=3:20%20pm&date=09/13/2011&arr=Depart&itinID=1

Parking lots are still being called parking lots, and crosswalks called crosswalks, but everything else I check without a name seems to be one or the other.

-Mele