Closed vpaturet closed 4 months ago
Attention: Patch coverage is 0%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 68.48%. Comparing base (
715be85
) to head (ec4baa3
).
Files | Patch % | Lines |
---|---|---|
...s/transmodel/OTPRequestTimeoutInstrumentation.java | 0.00% | 8 Missing :warning: |
...entripplanner/apis/transmodel/TransmodelGraph.java | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
The OTP request timeout feature provides a way to periodically check if the thread running an API request has been interrupted at a higher level (web server level). This allows for cancelling long-running queries. However this assumes that the running query will touch the code that checks for the interruption status. While this works well for trip planning queries, other categories of query may never touch the check points.
This PR adds an extra level of protection by checking periodically the OTP request timeout status at the GraphQL level, while data is being fetched.
Issue
No.
Unit tests
No.
Documentation
No.