search

opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.18k stars 1.02k forks source link

Use enum instead of boolean for real time update semantics #5892

Closed leonardehrenfried closed 3 months ago

leonardehrenfried commented 4 months ago

Summary

In #5871 we discussed that the boolean argument indicating if a realtime update is a full or an incremental one should be replaced with an enum, which this PR does.

Issue

4816

@vpaturet @habrahamsson-skanetrafiken Do you want to have this for SIRI as well?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (b9e54d2) to head (dfce217).

Files Patch % Lines
...r/ext/siri/updater/SiriETHttpTripUpdateSource.java 0.00% 3 Missing :warning:
...ner/updater/trip/GtfsRealtimeTripUpdateSource.java 50.00% 2 Missing :warning:
...pplanner/updater/trip/MqttGtfsRealtimeUpdater.java 0.00% 2 Missing :warning:
...pplanner/ext/siri/SiriTimetableSnapshotSource.java 0.00% 0 Missing and 1 partial :warning:
...pentripplanner/ext/siri/updater/SiriETUpdater.java 0.00% 1 Missing :warning:
...entripplanner/updater/trip/PollingTripUpdater.java 0.00% 1 Missing :warning:
...er/updater/trip/TripUpdateGraphWriterRunnable.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-2.x #5892 +/- ## ============================================= - Coverage 69.45% 69.45% -0.01% - Complexity 17064 17066 +2 ============================================= Files 1927 1928 +1 Lines 73578 73580 +2 Branches 7549 7550 +1 ============================================= + Hits 51106 51107 +1 - Misses 19847 19848 +1 Partials 2625 2625 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.