Closed habrahamsson-skanetrafiken closed 2 weeks ago
Attention: Patch coverage is 92.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 69.45%. Comparing base (
b9e54d2
) to head (960480d
). Report is 25 commits behind head on dev-2.x.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
This PR is a pure refactor and shouldn't change any behaviour.
The NearbyStopsFinder has three different behaviours depending on two different parameters:
ConsiderPatternsForDirectTransfers
feature is enabled.The different branches makes the code difficult to understand and difficult to test. This PR refactors this code to use the strategy pattern by extracting a common interface and having one class for each behaviour.
This work is in preparation of some work I need to do on access/egress search as part of #5848.
Unit tests
Unfortunately there is no tests for this piece of code. I would like to add some in a follow-up PR.
Documentation
I added and updated javadoc.
Bumping the serialization version id
Nope