search

opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.12k stars 1.01k forks source link

Convert remaining GTFS-RT tests to module tests #5916

Open leonardehrenfried opened 2 weeks ago

leonardehrenfried commented 2 weeks ago

Summary

This converts the remaining GTFS-RT realtime tests to module tests.

It also does a tiny bit of refactoring in the update handling code.

Issue

4002

Unit tests

Yes.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (cc46619) to head (3d138af). Report is 49 commits behind head on dev-2.x.

Files Patch % Lines
...pplanner/updater/trip/TimetableSnapshotSource.java 60.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-2.x #5916 +/- ## ============================================= + Coverage 69.43% 69.45% +0.01% Complexity 17066 17066 ============================================= Files 1934 1937 +3 Lines 73607 73688 +81 Branches 7540 7539 -1 ============================================= + Hits 51111 51177 +66 - Misses 19871 19883 +12 - Partials 2625 2628 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

leonardehrenfried commented 2 weeks ago

@habrahamsson-skanetrafiken I extract a few re-usable methods and made the tests a lot more compact and readable.