opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.18k stars 1.02k forks source link

Update Google Pubsub updater configuration #5927

Closed vpaturet closed 3 months ago

vpaturet commented 3 months ago

Summary

This PR:

Removed parameters:

Issue

No

Unit tests

Updated documentation test

Documentation

Updated documentation

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (827684a) to head (fc497ca). Report is 1 commits behind head on dev-2.x.

Files Patch % Lines
...er/google/SiriETGooglePubsubUpdaterParameters.java 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev-2.x #5927 +/- ## ============================================= + Coverage 69.43% 69.45% +0.01% Complexity 17065 17065 ============================================= Files 1934 1934 Lines 73606 73624 +18 Branches 7540 7539 -1 ============================================= + Hits 51109 51135 +26 + Misses 19870 19865 -5 + Partials 2627 2624 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vpaturet commented 3 months ago

@leonardehrenfried is the docs build failing due to a recent dependency upgrade?

leonardehrenfried commented 3 months ago

Something like that: https://github.com/magidoc-org/magidoc/issues/319#issuecomment-2185961583

leonardehrenfried commented 3 months ago

If you rebase the CI failure should be fixed.