Closed vpaturet closed 1 week ago
@leonardehrenfried should this be configured in the GTFS API as well?
Yes, we want it there, too. We could use a common logger name.
Attention: Patch coverage is 58.33333%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 69.45%. Comparing base (
827684a
) to head (8586376
). Report is 5 commits behind head on dev-2.x.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
GraphQL Java v22 removed support for logging errors in data fetchers (see https://github.com/graphql-java/graphql-java/pull/3403). This used to be controlled through the
notprivacysafe.graphql
logger. This PR adds back this feature by creating a custom DataFetcherExceptionHandler that logs at WARN level all errors thrown from data fetchers. This applies to the Transmodel API and the GTFS API.The logger is disabled by default in the logback.xml file shipped with OTP (as was the case with
notprivacysafe.graphql
)Issue
No
Unit tests
No
Documentation
No