Open t2gran opened 1 week ago
Attention: Patch coverage is 79.51426%
with 194 lines
in your changes missing coverage. Please review.
Project coverage is 69.78%. Comparing base (
dc56145
) to head (68e8867
). Report is 2 commits behind head on dev-2.x.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@t2gran Do you expect this PR to change the performance?
Also, you need to resolve some conflicts.
@t2gran Do you expect this PR to change the performance?
No, chaning Raptor Request should only affect performance for via searches. There are minor changes in the Raptor instrumentation (not in logic), so it might cause some problems for the JIT compiler - but I expect that it should not change.
Summary
This PR add back the via search to the Transmodel plan query. It does so by "chaining" Raptor requests. To be able to do this I had to refactor quite a bit. The functional changes is not that big.
This PR changes the Transmodel API and add a via location to the plan request. The
passThrough
feature works as before, but is merged with the new via API, and the oldpassThrough
arguments are deprecated.There are a few things left to implement:
I will create issues for reminding features, when this is merged.
The feature is a bit experimental and need "real life" testing - small changes and bug fixes are expected.
If this PR is too massive, then I can split it - but I believe there is little risk in breaking existing functionality. Splitting it in a pure feature PR and refactorings is difficult.
Issue
Related to : #4887
Unit tests
This PR refactor a lot of code and also add missing unit-test to some of the refactored classes. Almost all new code have unit-tests.
Documentation
✅ The API is documented and all new public classes/methods should have JavaDoc.
Changelog
✅
Bumping the serialization version id
✅ The routing request is changed