opentripplanner / OpenTripPlanner

An open source multi-modal trip planner
http://www.opentripplanner.org
Other
2.21k stars 1.03k forks source link

defaultStreetToStopTime by mode #786

Closed novalis closed 2 years ago

novalis commented 12 years ago

Guillaume Campagna writes:

If I understand correctly, the defaultStreetToStopTime is the time OTP add to take into consideration that it could take time to switch from the street to the actual transportation. This is the case in subways for example where you need to enter, pay, etc. That would take a few minutes.

The problem I have with that option is that it works on a per-GTFS only bases. That's great if all the GTFS files are relating on subways for example, but where GTFS file mixes transportation mode (and it happens a lot), that option is basically useless.

I would suggest to make that settings on a per transportation mode. That would permit to set defaultStreetToStopTime for subways to 120 and defaultStreetToStopTime for buses to something like 15 in the same GTFS.

samvermette commented 12 years ago

+1 would love to see this implemented

abyrd commented 4 years ago

Currently (8 years later) the street to stop time is set as follows:

if (modes != null && modes.contains(TransitMode.SUBWAY)) {
                stopVertex.setStreetToStopTime(subwayAccessTime);
            }

So this is now set for subway only. But we also have org.opentripplanner.ext.transmodelapi.model.TransportModeSlack which is applied to long distance rail, airplanes, etc. We should evaluate whether these different concepts can be merged.

On the other hand, "slack" is different than street-to-platform time in that transferring from one train to another, or one airplane to another would require the same amount of slack as boarding the first vehicle. But this subwayAccessTime is only needed to enter the station; for transfers you're already in the station.

t2gran commented 2 years ago

I will close this one - there does not seem to be enough interest in it to do it. The slack by mode also make this less of an issue (as @abyrd pointed out).