UI not reponding to URL search params changes when navigating back and forth..

opentripplanner / otp-react-redux

A library for writing modern OpenTripPlanner-compatible multimodal journey planning applications using React and Redux.

MIT License

74 stars 53 forks source link

UI not reponding to URL search params changes when navigating back and forth.. #1107

Open binh-dam-ibigroup opened 10 months ago

binh-dam-ibigroup commented 10 months ago

          Not holding this against this PR, but the search is getting cleared as a result of passing this second param. Although using the browser back navigation command does restore the search params, the UI is not picking those params. I'll file this as a separate issue.

_Originally posted by @binh-dam-ibigroup in https://github.com/opentripplanner/otp-react-redux/pull/1018#discussion_r1443059280_

daniel-heppner-ibigroup commented 10 months ago

The way routing is handled in general in the app is... not good. There's a lot of glue logic to hold the redux state in sync with the url state, and it doesn't always work.

If we can find a way to fix this that reduces the amount of glue, I think that would be very good.