opentripplanner / otp-react-redux

A library for writing modern OpenTripPlanner-compatible multimodal journey planning applications using React and Redux.
MIT License
74 stars 53 forks source link

Add Default Error Message in Cases Where there are No Itins #1166

Closed amy-corson-ibigroup closed 7 months ago

amy-corson-ibigroup commented 7 months ago

Description:

Adds a default OTP-style error message encouraging a user to change their search if we are returning a blank itinerary results pane.

PR Checklist:

amy-corson-ibigroup commented 7 months ago

@miles-grant-ibigroup We can add this to the error set in cases where the we actually return a response from the server! The issue is when the query is invalid (such as when a user only selects "rental" in the mode selector), we don't actually dispatch the routing request, and so there's no error set to add to.

miles-grant-ibigroup commented 7 months ago

@miles-grant-ibigroup We can add this to the error set in cases where the we actually return a response from the server! The issue is when the query is invalid (such as when a user only selects "rental" in the mode selector), we don't actually dispatch the routing request, and so there's no error set to add to.

That makes sense. But it definitely has to be added somewhere in the routing request process rather than at render time. What we have now is not ok