refactor: remove util/dropdown. import new building-block dropdown

opentripplanner / otp-react-redux

A library for writing modern OpenTripPlanner-compatible multimodal journey planning applications using React and Redux.

MIT License

70 stars 51 forks source link

refactor: remove util/dropdown. import new building-block dropdown #1241

Closed josh-willis-arcadis closed 1 month ago

josh-willis-arcadis commented 2 months ago

Description: Remove util/dropdown and use the new building-blocks component. blocked by: https://github.com/opentripplanner/otp-ui/pull/753

PR Checklist:

[ ] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
[ ] Are all languages supported (Internationalization/Localization)?
[ ] Are appropriate Typescript types implemented?

daniel-heppner-ibigroup commented 1 month ago

Uh oh, this breaks the percy tests because it changed one of the buttons that it tries to click on. Let me know if you need help fixing this! @josh-willis-arcadis

josh-willis-arcadis commented 1 month ago

@daniel-heppner-ibigroup looks like percy tests are failing because the submode selector has been moved. I think we should remove the tests for now, and then add more for the advanced panel.