search

opentripplanner / otp-react-redux

A library for writing modern OpenTripPlanner-compatible multimodal journey planning applications using React and Redux.
MIT License
75 stars 53 forks source link

Alert URL missing from alert in TransitLeg #149

Open landonreed opened 4 years ago

landonreed commented 4 years ago

When displaying an itinerary with alerts, the expanded alert does not render the alert URL. This prevents directing users of the trip planner to more information about the alert that may be contained on the agency website, which is especially useful if it contains dynamic or detailed instructions.

Current alert rendering

image

Alert data

image

Instead, we should add the URL with the hyperlinked More text

image

landonreed commented 4 years ago

From @fpurcell:

Dave, Noel & Jonathan (the Mkt. folks) want something similar. For the trimet.org redesign, here are the mockups around the itin and the alert link. https://xd.adobe.com/view/cef25753-fbd1-4e9d-7bf1-c5bc3bff8219-b8c3/screen/867915f3-2160-4c66-8f92-01fde40bdbeb/Planner-Itinerary

Noel writes (comments surrounding that mock up): "Clicking the alert will take you to that service's alerts page." (edited) new messages

So yes. I think a slot with customizable control would be best. But in the interim, if alerts all of a sudden start opening an alert page, that would work. That said, I would think (e.g., open the alert page in a new tab) would be important, since don't want an alert link to pull folks out of the trimet.org SPA.

fpurcell commented 4 years ago

FYI .. response from Randolph regarding alerts and otp-ui:

As seen on the current dev branch (of trimet.org), the linking of alerts is done through the AlertsBody component being invoked from within the default TransitLegBody in OTP-UI. We haven't modified it and I assume that making this customizeable is the topic of conversation? Josiah and Matherin and working on customizing the trimet.org itinerary view as we speak (customizing the itinerary body using those new slots). If we can customize via a slot then great. Otherwise, yes, having the ability to customize the target to _blank would be very helpful.