openucx / sparkucx

A high-performance, scalable and efficient ShuffleManager plugin for Apache Spark, utilizing UCX communication layer
https://www.sparkucx.org/
BSD 3-Clause "New" or "Revised" License
45 stars 31 forks source link

AZP: implement Azure based CI pipeline #10

Closed amaslenn closed 4 years ago

amaslenn commented 5 years ago

@petro-rudenko could you please review AZP runs? Does it looks good and does what your Action does?

I'm not sure mvn cmd is OK, at least package appears twice in: mvn -f /home/vsts/work/1/s/pom.xml -B package -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Pspark-2.3 package. Should I remove -B package from options (not quite familiar with mvn)?

petro-rudenko commented 5 years ago

-B is batch mode, to reduce verbosity in logs. OK, so AZP appends goal to the end. So no need then to have package at the beginning.

petro-rudenko commented 4 years ago

Can we also publish jar artifacts: https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/maven?view=azure-devops

petro-rudenko commented 4 years ago

We can publish just spark-ucx-1.0-for-spark-2.3.4-jar-with-dependencies.jar as a simple file

petro-rudenko commented 4 years ago

Something like this:

steps:
- publish: $(System.DefaultWorkingDirectory)/target/spark-ucx-*-jar-with-dependencies.jar
  artifact: spark-ucx-jar-with-dependencies.jar
petro-rudenko commented 4 years ago

Is it possible to download jar from artifacts? Don't see any: https://dev.azure.com/ucfconsort/sparkucx/_packaging?_a=feed

amaslenn commented 4 years ago

Is it possible to download jar from artifacts? Don't see any: https://dev.azure.com/ucfconsort/sparkucx/_packaging?_a=feed

Artifacts are attached to the build: https://dev.azure.com/ucfconsort/sparkucx/_build/results?buildId=2583&view=results

amaslenn commented 4 years ago

@petro-rudenko is that what you needed? Last results: https://dev.azure.com/ucfconsort/sparkucx/_build/results?buildId=2589&view=results

petro-rudenko commented 4 years ago

Ok, i thought on artifacts tab there would be a direct link to jar. But nevertheless it's ok, we'll be able to download and unpack zip file for tests.

amaslenn commented 4 years ago

We can also implement a real Maven publishing later if required.