search

openucx / sparkucx

A high-performance, scalable and efficient ShuffleManager plugin for Apache Spark, utilizing UCX communication layer
https://www.sparkucx.org/
BSD 3-Clause "New" or "Revised" License
44 stars 31 forks source link

Avoid get lock from synchronized in every shuffle #28

Closed wenxuanguan closed 3 years ago

wenxuanguan commented 3 years ago

1.get lock to init UcxNode only in the first shuffle 2.fix typo

wenxuanguan commented 3 years ago

cc @petro-rudenko Could you please have a look

wenxuanguan commented 3 years ago

retest this please

petro-rudenko commented 3 years ago

@wenxuanguan please rebase on master. I've merged fixes for CI.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_272) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. Read more here

wenxuanguan commented 3 years ago

@petro-rudenko Thanks for your review and guidance.