search

openucx / ucc

Unified Collective Communication Library
https://openucx.github.io/ucc/
BSD 3-Clause "New" or "Revised" License
195 stars 96 forks source link

TL/UCP: bugfix in allreduce dbt #907

Closed TaekyungHeo closed 8 months ago

TaekyungHeo commented 8 months ago

What

This PR updates the ID field of ucc_tl_ucp_allreduce_algs in src/components/tl/ucp/allreduce/allreduce.c. The incorrect ID UCC_TL_UCP_ALLREDUCE_ALG_SRA_KNOMIAL has been replaced with the correct UCC_TL_UCP_ALLREDUCE_ALG_DBT.

Why ?

The change addresses a bug where the ID field of UCC_TL_UCP_ALLREDUCE_ALG_DBT was mistakenly set to UCC_TL_UCP_ALLREDUCE_ALG_SRA_KNOMIAL. This fix ensures that the ID accurately reflects the corresponding algorithm, aligning with the intended design and improving the functionality of the component.

How ?

The fix was straightforward - the incorrect ID in the specified file was simply replaced with the correct ID. This ensures that the UCC_TL_UCP_ALLREDUCE_ALG_DBT is now accurately represented in the system.

swx-jenkins3 commented 8 months ago

Can one of the admins verify this patch?

Sergei-Lebedev commented 8 months ago

ok to test

manjugv commented 8 months ago

Can you plz port v1.3.0 branch?