search

openucx / ucc

Unified Collective Communication Library
https://openucx.github.io/ucc/
BSD 3-Clause "New" or "Revised" License
195 stars 96 forks source link

TL/MLX5: fix IPv6 address conversion in inet_ntop #928

Open miharulidze opened 7 months ago

miharulidze commented 7 months ago

What

This commit fixes the conversion of binary IPv6 address into the human-readable string using inet_ntop.

Why ?

In our testing environment, the debug output of MLX5 TL prints garbage IPv6 addresses during the multicast initialization/teardown phase.

How ?

Pass sin6_addr field of type struct in6_addr that is the part of the sockaddr_in6 structure, as specified in https://man7.org/linux/man-pages/man3/inet_ntop.3.html

swx-jenkins3 commented 7 months ago

Can one of the admins verify this patch?

Sergei-Lebedev commented 7 months ago

Hi @miharulidze, thanks for the PR, do you have contributor agreement signed of?

miharulidze commented 7 months ago

@Sergei-Lebedev nope - but can do within the week. Should I ack you when it's done?

Sergei-Lebedev commented 7 months ago

@Sergei-Lebedev nope - but can do within the week. Should I ack you when it's done?

Yes, please. We need CLA to merge the PR.