search

openucx / ucc

Unified Collective Communication Library
https://openucx.github.io/ucc/
BSD 3-Clause "New" or "Revised" License
177 stars 85 forks source link

fix unannotated fall-through between switch labels in utils/ucc_coll_utils.h #984

Open bunnypak opened 2 weeks ago

bunnypak commented 2 weeks ago

What

fix unannotated fall-through between switch labels in utils/ucc_coll_utils.h

Why ?

When building on x86_64 Linux and clang 15,

...
utils/ucc_coll_utils.h:291:5: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
    default:
    ^
...
swx-jenkins3 commented 2 weeks ago

Can one of the admins verify this patch?

Sergei-Lebedev commented 2 weeks ago

ok to test

manjugv commented 2 weeks ago

@bunnypak What is your affiliation? have you or your institution signed CLA?

manjugv commented 2 weeks ago

@bunnypak What is your affiliation? have you or your institution signed CLA?

@bunnypak What is your affiliation? have you or your institution signed CLA?

https://github.com/openucx/ucc?tab=readme-ov-file#contributing

bunnypak commented 2 weeks ago

@bunnypak What is your affiliation? have you or your institution signed CLA?

Meta. Personally no. Not sure about my institution.