Open shssf opened 7 years ago
Also, the completion procedure is not clearly stated or referenced.
It would be greate to mention that cb
argument might be NULL
(currently it can't be - failed) and ucp_request_is_completed()
.
We have two methods to the request status tracking:
cb
)
1a. Need to explain why the line request->completed = 0; /* Reset request state before recycling it */
in ucp_hello_world is needed.Any of these methods can be used by the user choice.
The function
ucp_tag_send_nb()
can work with different datatypes (contig
,iov
,generic
) and input parameterconst void *buffer
expected with different structs. In case of simplecontig
datatype it expectschar *
but withiov
datatype it expectsucp_dt_iov_t*
it would be good to point this important difference explicitly. Current documentation looks like: