openucx / ucx

Unified Communication X (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group)
http://www.openucx.org
Other
1.13k stars 423 forks source link

Build is failing #7127

Closed gggh000 closed 3 years ago

gggh000 commented 3 years ago

Describe the bug

Build is failing with log below:

nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx$ ./autogen.sh
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I config/m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf
configure.ac:79: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx$ git branch -r
  origin/HEAD -> origin/master
  origin/gh-pages
  origin/master
  origin/revert-7023-release_ci
  origin/topic/iodemo-assert-servers
  origin/v1.10.x
  origin/v1.11.x
  origin/v1.2.x
  origin/v1.3.x
  origin/v1.4.x
  origin/v1.5.x
  origin/v1.6.x
  origin/v1.7.x
  origin/v1.8.x
  origin/v1.9.x
nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx$ git checkout v1.11.x
Branch 'v1.11.x' set up to track remote branch 'v1.11.x' from 'origin'.
Switched to a new branch 'v1.11.x'
nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx$ ./autogen.sh
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I config/m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf
configure.ac:79: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx

Steps to Reproduce

On ubuntu machine (18.04), just simply checkout and follow the first instruction: . ./autogen.sh caused this.

No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.5 LTS
Release:        18.04
Codename:       bionic
nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx$ uname -r
5.4.0-42-generic
nonroot@nonroot-Standard-PC-i440FX-PIIX-1996:~/git.co/ucx$

Additional information (depending on the issue)

gggh000 commented 3 years ago

After installing libtool, it worked. It may be good idea to add libtool installation as requirement.

shamisp commented 3 years ago

@gggh000 AC_PROG_LIBTOOL is a "autotools" way to configure libtool. Checking for the presence of libtool binary with which libtool is not a very robust way of checking the functionality of libtool installation since other parts of the tool can be missing. Executing the macro is a relatively reliable way to verify functionality of the tool.

shamisp commented 3 years ago

I'm closing for now. If you have an idea how libtool detection can be implemented in a robust way, please let us know.