openucx / xccl

Other
22 stars 14 forks source link

xccl/core: Bug fix in the OOB allgather code #122

Closed pavanbalaji closed 3 years ago

pavanbalaji commented 3 years ago

The OOB allgather code expects each caller process to pass in its rank, based on the API. But the current implementation simply passes "0" for all processes. This worked fine so far because none of the application codes used that value, but it could break a future code that relies on that parameter.

Signed-off-by: Pavan Balaji pavanbalaji.work@gmail.com

pavanbalaji commented 3 years ago

Hi @Sergei-Lebedev or @bureddy: Is this ready to be merged into master?

bureddy commented 3 years ago

@Sergei-Lebedev can you merge?

Sergei-Lebedev commented 3 years ago

@pavanbalaji pls rebase and I will merge

pavanbalaji commented 3 years ago

@pavanbalaji pls rebase and I will merge

@Sergei-Lebedev Done.