openui / open-ui

Maintain an open standard for UI and promote its adherence and adoption.
https://open-ui.org
Other
3.59k stars 191 forks source link

Add checkmark to select explainer #1059

Closed josepharhar closed 6 months ago

josepharhar commented 6 months ago

Fixes https://github.com/openui/open-ui/issues/863

lukewarlow commented 6 months ago

I'm interested to here the reasoning for why ::before is easy but ::marker is hard?

josepharhar commented 6 months ago

As it's currently implemented in chromium, setting display isn't allowed on ::marker I think. There also might be restrictions on which elements you can put ::marker on and how its rendered or what it renders. ::before on the other hand you can do whatever you want.

I think it would be easier to create a new pseudo element than reuse ::marker, but I think that's another discussion we can have later.