search

openui / open-ui

Maintain an open standard for UI and promote its adherence and adoption.
https://open-ui.org
Other
3.59k stars 191 forks source link

Link delegation explainer - review updates #1111

Closed scottaohara closed 3 weeks ago

scottaohara commented 1 month ago

Follow on to https://github.com/openui/open-ui/pull/1109

This PR updates a lot of the explainer.

Additional accessibility callouts, use cases, questions, and clarifications have been made.

Moves the file from the root folder to the correct components folder.

cc @noamr, @nmn, @mfreed7

scottaohara commented 1 month ago

things from my abandoned review that i didn't address in this PR:

the reddit example is a good one - though the need for this with the reddit example is maybe not the best. The Walmart example should probably be better called out - particularly the product listing example. But it might also be worth noting that Walmart's treatment is not the best (use of duplicate links, both exposed to screen readers) - but it being problematic is a positive for why a standardization of this feature would be useful. The rotten tomatoes citation.... i honestly have no idea which pattern on that site would fit into the CSS or JS examples.... but i did see some examples of entire sections of content wrapped by hyperlinks - which prompted me to include that example in this explainer.

edit: my latest commit removes the rotten tomatoes example and instead includes amazon and best buy - as i was able to find instances of this pattern easily on those sites. we can obviously pull the rotten tomatoes one back in once the pattern is identified (very sorry if i'm somehow just completely missing it)

noamr commented 4 weeks ago

I think this can be submitted? I don't have write access

mfreed7 commented 3 weeks ago

I think this can be submitted? I don't have write access

Done!