search

openui / open-ui

Maintain an open standard for UI and promote its adherence and adoption.
https://open-ui.org
Other
3.59k stars 191 forks source link

Update explainer with button behaviors #1125

Open mfreed7 opened 2 weeks ago

mfreed7 commented 2 weeks ago

Also remove the split button section.

mfreed7 commented 2 weeks ago

Do we need to say anything about, the button needs to be the first child element of the select and no other buttons in the select participate this way?

Is this a requirement?

scottaohara commented 1 week ago

having the button part being actually inert won't cause any issues in calculating the value of the select, will it?

as we had previously resolved that if someone were to do:

<select>
  <button> foo <selectedcontent>bar <span class="hide">baz</span></selectedcontent></button>
  <option selected>bar <span class="hide">baz</span></option>
</select>

<style>
  selectedcontent .hide { display: none }
</style>

that the value for the select would be returned as "foo bar" instead of the option's "bar baz" text

aleventhal commented 1 week ago

It shouldn't. But we can prototype. I'm sure I can work around any issues.

On Mon, Nov 11, 2024, 10:01 AM scottaohara @.***> wrote:

having the button part being actually inert won't cause any issues in calculating the value of the select, will it?

as we had previously resolved that if someone were to do:

that the value for the select would be returned as "foo bar" instead of the option's "bar baz" text

— Reply to this email directly, view it on GitHub https://github.com/openui/open-ui/pull/1125#issuecomment-2468385089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKQAZSE7P2TB5QHTUFBOIL2ADBFZAVCNFSM6AAAAABROIBNOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRYGM4DKMBYHE . You are receiving this because you commented.Message ID: @.***>

aleventhal commented 1 week ago

Not sure actually. But it feels to me like it would lead to some nice predictability.

On Fri, Nov 8, 2024, 5:04 PM Mason Freed @.***> wrote:

Do we need to say anything about, the button needs to be the first child element of the select and no other buttons in the select participate this way?

Is this a requirement?

— Reply to this email directly, view it on GitHub https://github.com/openui/open-ui/pull/1125#issuecomment-2465820431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKQAZVWETB3MTUGJTUXDJLZ7UYOLAVCNFSM6AAAAABROIBNOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVHAZDANBTGE . You are receiving this because you commented.Message ID: @.***>