openv / vcontrold

:fire: vcontrold Daemon for control and logging of Viessmann® type heating devices
https://github.com/openv/openv/wiki
GNU General Public License v3.0
100 stars 54 forks source link

Fix possible problems detected via CodeQL codescanning workflow #103

Closed speters closed 1 year ago

speters commented 1 year ago

This fixes possible problems being detected by the CodeQL codescanning workflow.

Problems contained:

Please be so kind as to test this version.

hmueller01 commented 1 year ago

I think it is not good to merge a pull request right away. This way it is not possible to add more changes. In many cases the reserved memory char string[100]; is not needed any more. I'll pull the new master and test it. :-)

hmueller01 commented 1 year ago

New version is running. I'll open a new PR to remove these unused string's ...

speters commented 1 year ago

I was solely concetrated on those easy fixes. Shame on me. And thx for having an eye on it.

hmueller01 commented 1 year ago

Until now it works like before. As it is already merged it can be released ;-) Pls review #105 (I tested with this PR ...)