search

openv / vcontrold

:fire: vcontrold Daemon for control and logging of Viessmann® type heating devices
https://github.com/openv/openv/wiki
GNU General Public License v3.0
102 stars 55 forks source link

Update vclient.c #120

Open ergorion opened 1 year ago

ergorion commented 1 year ago

small fix to allow the output of system time in a csv file.

hmueller01 commented 1 year ago

I think it's not good to have getSystemTime hard coded in vclient.c. It's just a tag in vito.xml, e.g.: 

    <command name="getSystemTime" protocmd="getaddr">
      <addr>088E</addr>
      <len>8</len>
      <unit>TI</unit>
      <description>Ermittle Systemzeit</description>
      <device ID="2053"/>
    </command>

But I don't have a better idea right now ...

ergorion commented 1 year ago

You are right, it's hard coded. But it helps people to simply output the system date... From what I saw on the web, I was not the only one with this problem.