openv / vcontrold

:fire: vcontrold Daemon for control and logging of Viessmann® type heating devices
https://github.com/openv/openv/wiki
GNU General Public License v3.0
101 stars 54 forks source link

Transition to cmake #2

Closed l3u closed 6 years ago

l3u commented 6 years ago

I think it's better to create a pull request for this, as discussing there will also track further commits.

hmueller01 commented 6 years ago

Compiles on MacOSX 10.11 with cmake from homebrew. -> confirmed Maybe probonopd can confirm for openwrt: https://github.com/probonopd/vcontrold-for-openwrt

hmueller01 commented 6 years ago

Hi, can you please add a README.md to explain how the build process is done. You have written it before somewhere but I can't find it any more. Most important for me is a note, how to change the install path without changing CMakeLists.txt: cmake -DCMAKE_INSTALL_PREFIX=/usr/local .. Tx

l3u commented 6 years ago

Here you go.

hmueller01 commented 6 years ago

Tx. But I find it more convenient to set the install prefix more permanent, instead of giving the path to every make install. I would never install a self compiled code to /usr. /usr holds only installed packages (using e.g. apt-get). Everything else belongs to /usr/local or /opt ... So for me it would be nice, it you could also add

If you want to install the package with another prefix, use make DESTDIR=<PREFIX> install or cmake -DCMAKE_INSTALL_PREFIX=<PREFIX> ..

l3u commented 6 years ago

Well, I come from Gentoo, all our code is self-compiled ;-) But of course, you can tell cmake directly about another prefix. /opt is for (binary) third-party stuff btw. /usr/local is for what you mean, for software installed for this one system, independent of the distribution.

speters commented 6 years ago

Thx, cmake is now merged into master.

Most of the legacy-files have been removed to cut with old stuff. These are now found in the "legacy" branch.

The build instructions formerly written in the short top-level README.md are now in doc/INSTALL.md

l3u commented 6 years ago

Nice :-)