search

openva / court-audio

Bulk data pertaining to Supreme Court of Virginia audio recordings of oral arguments.
MIT License
0 stars 0 forks source link

Make "transcript" a full URL, not just a path #5

Open reefdog opened 1 year ago

reefdog commented 1 year ago

First, amazing work! 👏

Second, I recommend changing the transcript attribute to return a full URL, not just a path. This makes it a little easier to use because the client only needs the JSON, not information about where the JSON came from.

This does slightly complicate generation since you either have to hardcode in the domain (drake no) or make it reliant on an env var (drake aha) but that seems like a worthwhile trade-off.

Happy to submit this as a PR if desired.

https://github.com/openva/court-audio/blob/13d34f380cc8b54d8c397e45e82f76dff9dd1e16/linker.sh#L24

waldoj commented 1 year ago

I intend to do that, but haven't yet because there's a decent chance that I'll register a domain for this in the next few day. :)

reefdog commented 1 year ago

Oh! I figured courtaudio.openva.com was canonical. Sure, wait until then. :)