openva / crump

A parser for the Virginia State Corporation Commission's business registration records.
https://vabusinesses.org/
MIT License
20 stars 3 forks source link

Replace lousy geodata file hack #78

Open waldoj opened 10 years ago

waldoj commented 10 years ago

Instead of finding all address-data fields in the field maps in Crump, instead we just explicitly look for file numbers 2, 3, or 9, and manually concatenate the relevant fields. This is not the right way to do this.

Instead, figure out how to maintain dict order, to get the address in the proper order. (e.g., "Charlottesville, 123 Main St., 22902, VA.") My guess is that we can use the order of the fields in the YAML files as an external ordering reference. Once we do that, we can find all groups with "address" in their name and "geo_" in search > type, and combine those fields to hash them.